New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm module export #808

Merged

luisrudge merged 3 commits into master from fix-npm-module-export

Jul 18, 2018

Contributor

luisrudge commented Jul 18, 2018

Remove rollup-plugin-uglify because it doesn't support minifying ES6+. Using rollup-plugin-terser instead
Don't generate prod files when in dev mode
instead of using main/browser in package.json, using module/main (ES modules, UMD bundle)
- This follows best practices outlined here, here and here.

luisrudge added 3 commits

July 18, 2018 14:14


          Try1

c048fc4


          Don't build prod files in dev time

f463b83


          Removing rollup-plugin-uglify

eab26c5

luisrudge added the CH: Fixed label

luisrudge modified the milestone: v9.7.3

lbalmaceda approved these changes

View reviewed changes

Contributor

lbalmaceda left a comment

luisrudge merged commit 09c61c2 into master

luisrudge deleted the fix-npm-module-export branch

July 18, 2018 18:35

rafaelrinaldi commented Jul 20, 2018

FYI 9.7.2 was totally broken for me and this PR fixed it. I'm using the beta version for now.

Contributor Author

luisrudge commented Jul 20, 2018

@rafaelrinaldi Thanks for letting us know. Can you tell me your scenario so I can compare with others?

bors bot referenced this pull request in mozilla/delivery-console


          Merge #307

68f8a91

307: Update dependency auth0-js to v9.7.3 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [auth0-js](https://github.com/auth0/auth0.js) from `v9.6.1` to `v9.7.3`



<details>
<summary>Release Notes</summary>

### [`v9.7.3`](https://github.com/auth0/auth0.js/blob/master/CHANGELOG.md#v973httpsgithubcomauth0auth0jstreev973-2018-07-23)
[Compare Source](auth0/auth0.js@v9.7.2...v9.7.3)
[Full Changelog](auth0/auth0.js@v9.7.3-beta1...v9.7.3)

**Fixed**
- Fix npm module export [\#&#8203;808](`https://github.com/auth0/auth0.js/pull/808`) ([luisrudge])

---

### [`v9.7.2`](https://github.com/auth0/auth0.js/blob/master/CHANGELOG.md#v972httpsgithubcomauth0auth0jstreev972-2018-07-13)
[Compare Source](auth0/auth0.js@v9.7.1...v9.7.2)
[Full Changelog](auth0/auth0.js@v9.7.1...v9.7.2)

**Fixed**
- Fix default export for auth0js [\#&#8203;803](`https://github.com/auth0/auth0.js/pull/803`) ([luisrudge])

---

### [`v9.7.1`](https://github.com/auth0/auth0.js/blob/master/CHANGELOG.md#v971httpsgithubcomauth0auth0jstreev971-2018-07-13)
[Compare Source](auth0/auth0.js@v9.7.0...v9.7.1)
[Full Changelog](auth0/auth0.js@v9.7.0...v9.7.1)

**Fixed**
- Fix build folder not being published in the tag [\#&#8203;801](`https://github.com/auth0/auth0.js/pull/801`) ([luisrudge])

---

### [`v9.7.0`](https://github.com/auth0/auth0.js/blob/master/CHANGELOG.md#v970httpsgithubcomauth0auth0jstreev970-2018-07-12)
[Compare Source](auth0/auth0.js@v9.6.1...v9.7.0)
[Full Changelog](auth0/auth0.js@v9.6.1...v9.7.0)

**Added**
- Add SRI hashes to the cdn [\#&#8203;782](`https://github.com/auth0/auth0.js/pull/782`) ([luisrudge])

**Fixed**
- options is optional in WebAuth.prototype.authorize [\#&#8203;789](`https://github.com/auth0/auth0.js/pull/789`) ([behrangsa])
- Removing `domain` option from methods (it can't be overridden) [\#&#8203;781](`https://github.com/auth0/auth0.js/pull/781`) ([luisrudge])

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels