Parse file protocol from Url #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this library is used in electron, locations in most cases are files
luisrudge
suggested changes
Oct 23, 2018
|
ping @anion155 |
|
Will add. In a moment. |
|
There is 'url' helper, used only once in 'web-auth/popup', shouldn't it be 'objectHelper.getOriginFromUrl'? |
anion155
commented
Nov 7, 2018
There was a problem hiding this comment.
@luisrudge, added test 'getLocationFromUrl' for 'file' protocol
luisrudge
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this library is used in electron, locations in most cases are files