Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added authorizationCodeGrant method to OAuthAuthenticator #290

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

cwurtz
Copy link
Contributor

@cwurtz cwurtz commented Jul 27, 2018

This PR adds a method to exchange an authorization code for a Bearer token containing the access_token & id_token.

closes: #284

Added method to exchange an authorization code for a Bearer token containing the access_token & id_token.
@luisrudge
Copy link
Contributor

Thanks for the PR! Do you think it makes more sense to call it authorizationCodeGrant since that's how we document it?

@cwurtz
Copy link
Contributor Author

cwurtz commented Aug 8, 2018

I made it authorizeCodeGrant to denote the action, but looking at the docs, "Authorization Code" is more of an adjective describing the grant type so it probably doesn't make sense for me to have named it how I did. authorizationCodeGrant sounds like a better option to me as well

Changed the function name to authorizationCodeGrant for all usages and comments
@cwurtz
Copy link
Contributor Author

cwurtz commented Aug 8, 2018

Updated the PR to change authorizeCodeGrant -> authorizationCodeGrant

@luisrudge luisrudge changed the title Added authorizeCodeGrant() to OAuthAuthenticator Added authorizationCodeGrant method to OAuthAuthenticator Aug 8, 2018
@luisrudge luisrudge merged commit fcf3e71 into auth0:master Aug 8, 2018
@luisrudge luisrudge added this to the v2.12.0 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to get user tokens
2 participants