Update getRulesConfigs docs to include callback #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
mentioned this pull request
damieng
approved these changes
Mar 25, 2020
|
Thanks! |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have submitted a TypeScript PR a few days ago to include types for rules configs functions and with a reviewer we detected a mismatch in a library docs:
https://auth0.github.io/node-auth0/module-management.ManagementClient.html#getRulesConfigs that define
getRulesConfigs()without a callback argument, however in example and the source code itself the callback is expected.We would appreciate it if we could have the updated docs with a
getRulesConfigs(cb).This is a tiny PR, however let me know if I am wrong in my understanding or if I can help you any further.
Kind regards :)