Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for prompts and custom texts #533

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

davidpatrick
Copy link
Contributor

@davidpatrick davidpatrick commented Sep 14, 2020

Changes

Adding support for prompts and prompts custom texts.

GET /api/v2/prompts
PATCH /api/v2/prompts
GET /api/v2/prompts/{prompt}/custom-text/{language}
PUT /api/v2/prompts/{prompt}/custom-text/{language}

Closes #525
Closes #526

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@davidpatrick davidpatrick requested a review from a team September 14, 2020 04:11
@jimmyjames jimmyjames self-requested a review September 14, 2020 14:17
jimmyjames
jimmyjames previously approved these changes Sep 14, 2020
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompt manager is missing from this index file https://github.com/auth0/node-auth0/blob/master/src/management/index.js. Should we add it there as well?

test/management/prompts.tests.js Outdated Show resolved Hide resolved
src/management/PromptsManager.js Show resolved Hide resolved
src/management/index.js Show resolved Hide resolved
@davidpatrick davidpatrick merged commit 160b647 into master Sep 17, 2020
@davidpatrick davidpatrick added this to the v2.29.0 milestone Sep 23, 2020
@davidpatrick davidpatrick mentioned this pull request Sep 23, 2020
@evansims evansims deleted the prompts-manager branch June 13, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PromptsManager supporting custom text PromptsManager was removed from Management API
3 participants