Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update managers #883

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Update managers #883

merged 6 commits into from
Jul 18, 2023

Conversation

frederikprijck
Copy link
Member

Changes

This PR updates the managers by:

  • Removing the /attack-protection/brute-force-protection/defaults endpoint
  • Correctly typing void calls
  • Adding endpoints for client credentials
  • Update some docs for connections
  • Couple of model updates

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner July 13, 2023 13:39
@frederikprijck frederikprijck merged commit eacb6e6 into beta Jul 18, 2023
@frederikprijck frederikprijck deleted the feat/update-managers branch July 18, 2023 09:34
@frederikprijck frederikprijck mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @adamjmcgrath