Fix samples #1038
Merged
Fix samples #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The merge request looks good. Should we add an automatic logic like this in OidcClient.ts (Line 235): // specify the client Identifier when post_logout_redirect_uri is used but id_token_hint is not
if ( !client_id && post_logout_redirect_uri && !id_token_hint) {
client_id = this.settings.client_id;
}
const request = new SignoutRequest({
... |
|
Got it. |
perguth
commented
Jun 10, 2023
perguth
commented
Jun 10, 2023
perguth
commented
Jun 10, 2023
Remove logs
The listeners in line 9-13 are passing in an event object as first parameter. So the previous code worked when using the `followLinks` flow but not the manual one.
pamapa
approved these changes
Jun 12, 2023
|
thanks for contributing |
perguth
added a commit
to perguth/oidc-client-ts
that referenced
this pull request
Jun 15, 2023
1 task
dbfr3qs
pushed a commit
to dbfr3qs/oidc-client-ts
that referenced
this pull request
Apr 3, 2024
* pass callback URLs to login/logout requests in samples to prevent fatal errors * allow client_id to logout request to prevent fatal errors (tested against Keycloak - either "id_token_hint" (already available) or "client_id" (missing till now) are required when using post_logout_redirect_uri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes/fixes --
client_idto logout request to prevent fatal errors (tested against Keycloak - either "id_token_hint" (already available) or "client_id" (missing till now) are required when usingpost_logout_redirect_uri)Checklist