feat: Add retry logic for bulk imports based on work in the zed CLI #165
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
| } | ||
| ) | ||
|
|
||
| type RetryableClient struct { |
There was a problem hiding this comment.
Add doc comments on all exported functions and types
There was a problem hiding this comment.
I believe I have done this now. If I missed one, let me know.
There was a problem hiding this comment.
missed one:
// NewRetryableClient initializes a brand new client for interacting
// with Authzed.
|
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: Chance Murray <[email protected]>
chancesm
force-pushed
the
retryable-import-client
branch
from
bf1b18c
to
6fb5141
Compare
Signed-off-by: Chance Murray <[email protected]>
v1/retryable_client.go
Outdated
| ) | ||
|
|
||
| // ConflictStrategy is an enumeration type that represents the strategy to be used | ||
| // when a conflict occurs during a bulk import of relationships in Authzed. |
| type ConflictStrategy int | ||
|
|
||
| const ( | ||
| Fail ConflictStrategy = iota |
There was a problem hiding this comment.
Move the comment for each to above each value
v1/retryable_client.go
Outdated
| } | ||
| ) | ||
|
|
||
| // RetryableClient represents an open connection to Authzed with |
There was a problem hiding this comment.
I'll fix this, but I was following the pattern set on the doc comments for the other clients. They all say Authzed.
There was a problem hiding this comment.
Yeah, we're transitioning those to make it match the fact that this is open source
Signed-off-by: Chance Murray <[email protected]>
chancesm
force-pushed
the
retryable-import-client
branch
from
d4811e0
to
6e04b69
Compare
Signed-off-by: Chance Murray <[email protected]>
Tests can be added later. I just wanted an initial review of the code first.