Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate API for 53e6b1087a076a9802ed2218f3a43404f779a1ff which includes transaction metadata #246

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Regenerate API for 53e6b1087a076a9802ed2218f3a43404f779a1ff which includes transaction metadata #246

merged 1 commit into from
Oct 1, 2024

Conversation

josephschorr
Copy link
Member

No description provided.

@josephschorr josephschorr requested a review from a team as a code owner October 1, 2024 18:09
tstirrat15
tstirrat15 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm surprised that the diff is as large as it is for the size of the corresponding changeset, but that seems to be a result of using binary representations in the generated code

@josephschorr josephschorr added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@josephschorr josephschorr added this pull request to the merge queue Oct 1, 2024
Merged via the queue into authzed:main with commit 27cc182 Oct 1, 2024
11 checks passed
@josephschorr josephschorr deleted the add-transaction-metadata branch October 1, 2024 20:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephschorr @tstirrat15