Skip to content

Commit

Permalink
Enable LRv2 by default and update the steelthread tests
Browse files Browse the repository at this point in the history 
The steelthread tests have to be updated because the "indirect" tests now return results in a slightly different order in LRv2. Manually verified that the results themselves are the same (except duplicates, which are allowed)
  • Loading branch information
@josephschorr
josephschorr committed Sep 25, 2024
1 parent 7f6f270 commit 320dae5
Show file tree
Hide file tree
Showing 10 changed files with 652 additions and 9 deletions.
14 changes: 7 additions & 7 deletions internal/services/steelthreadtesting/definitions.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 5,
},
resultsFileName: "basic-lookup-resources-cursored-lookup-resources-for-fred-page-size-5-results.yaml",
resultsFileName: "indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-5-results.yaml",
},
{
name: "cursored indirect lookup resources for fred, page size 16",
Expand All @@ -171,7 +171,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 16,
},
resultsFileName: "basic-lookup-resources-cursored-lookup-resources-for-fred-page-size-16-results.yaml",
resultsFileName: "indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-16-results.yaml",
},
{
name: "cursored indirect lookup resources for fred, page size 53",
Expand All @@ -183,7 +183,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 53,
},
resultsFileName: "basic-lookup-resources-cursored-lookup-resources-for-fred-page-size-53-results.yaml",
resultsFileName: "indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-53-results.yaml",
},
{
name: "cursored indirect lookup resources for fred, page size 54",
Expand All @@ -195,7 +195,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 54,
},
resultsFileName: "basic-lookup-resources-cursored-lookup-resources-for-fred-page-size-54-results.yaml",
resultsFileName: "indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-54-results.yaml",
},
{
name: "cursored indirect lookup resources for fred, page size 100",
Expand All @@ -207,7 +207,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 100,
},
resultsFileName: "basic-lookup-resources-cursored-lookup-resources-for-fred-page-size-100-results.yaml",
resultsFileName: "indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-100-results.yaml",
},
{
name: "indirect without other permission, page size 5",
Expand All @@ -219,7 +219,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 5,
},
resultsFileName: "basic-lookup-resources-indirect-without-other-permission-page-size-5-results.yaml",
resultsFileName: "indirect-lookup-resources-indirect-without-other-permission-page-size-5-results.yaml",
},
{
name: "indirect without other permission, page size 16",
Expand All @@ -231,7 +231,7 @@ var steelThreadTestCases = []steelThreadTestCase{
"subject_object_id": "fred",
"page_size": 16,
},
resultsFileName: "basic-lookup-resources-indirect-without-other-permission-page-size-16-results.yaml",
resultsFileName: "indirect-lookup-resources-indirect-without-other-permission-page-size-16-results.yaml",
},
{
name: "vsb_plus_nil, page size 16",
Expand Down
94 changes: 94 additions & 0 deletions ...s/indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-100-results.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
---
- - 'doc-0'
- 'doc-1'
- 'doc-10'
- 'doc-11'
- 'doc-12'
- 'doc-13'
- 'doc-14'
- 'doc-15'
- 'doc-16'
- 'doc-17'
- 'doc-18'
- 'doc-19'
- 'doc-2'
- 'doc-20'
- 'doc-21'
- 'doc-22'
- 'doc-23'
- 'doc-24'
- 'doc-25'
- 'doc-26'
- 'doc-27'
- 'doc-28'
- 'doc-29'
- 'doc-3'
- 'doc-30'
- 'doc-31'
- 'doc-32'
- 'doc-33'
- 'doc-34'
- 'doc-35'
- 'doc-36'
- 'doc-37'
- 'doc-38'
- 'doc-39'
- 'doc-4'
- 'doc-40'
- 'doc-41'
- 'doc-42'
- 'doc-43'
- 'doc-44'
- 'doc-45'
- 'doc-46'
- 'doc-47'
- 'doc-48'
- 'doc-49'
- 'doc-5'
- 'doc-50'
- 'doc-51'
- 'doc-52'
- 'doc-53'
- 'doc-54'
- 'doc-55'
- 'doc-56'
- 'doc-57'
- 'doc-58'
- 'doc-59'
- 'doc-6'
- 'doc-60'
- 'doc-61'
- 'doc-62'
- 'doc-63'
- 'doc-64'
- 'doc-65'
- 'doc-66'
- 'doc-67'
- 'doc-68'
- 'doc-69'
- 'doc-7'
- 'doc-70'
- 'doc-71'
- 'doc-72'
- 'doc-73'
- 'doc-74'
- 'doc-75'
- 'doc-76'
- 'doc-77'
- 'doc-78'
- 'doc-79'
- 'doc-8'
- 'doc-9'
- 'doc-90'
- 'doc-91'
- 'doc-92'
- 'doc-93'
- 'doc-94'
- 'doc-95'
- 'doc-96'
- 'doc-97'
- 'doc-98'
- 'doc-99'
- 'public-doc-0'
- 'public-doc-1'
- 'public-doc-3'
94 changes: 94 additions & 0 deletions ...ts/indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-16-results.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
---
- - 'doc-0'
- 'doc-90'
- 'doc-91'
- 'doc-92'
- 'doc-93'
- 'doc-94'
- 'doc-95'
- 'doc-96'
- 'doc-97'
- 'doc-98'
- 'doc-99'
- - 'doc-1'
- 'doc-10'
- 'doc-11'
- 'doc-12'
- 'doc-13'
- 'doc-14'
- 'doc-15'
- 'doc-16'
- 'doc-17'
- 'doc-18'
- 'doc-19'
- 'doc-2'
- 'doc-20'
- 'doc-21'
- 'doc-22'
- 'doc-23'
- - 'doc-24'
- 'doc-25'
- 'doc-26'
- 'doc-27'
- 'doc-28'
- 'doc-29'
- 'doc-3'
- 'doc-30'
- 'doc-31'
- 'doc-32'
- 'doc-33'
- 'doc-34'
- 'doc-35'
- 'doc-36'
- 'doc-37'
- 'doc-38'
- - 'doc-39'
- 'doc-4'
- 'doc-40'
- 'doc-41'
- 'doc-42'
- 'doc-43'
- 'doc-44'
- 'doc-45'
- 'doc-46'
- 'doc-47'
- 'doc-48'
- 'doc-49'
- 'doc-5'
- 'doc-50'
- 'doc-51'
- 'doc-52'
- - 'doc-53'
- 'doc-54'
- 'doc-55'
- 'doc-56'
- 'doc-57'
- 'doc-58'
- 'doc-59'
- 'doc-6'
- 'doc-60'
- 'doc-61'
- 'doc-62'
- 'doc-63'
- 'doc-64'
- 'doc-65'
- 'doc-66'
- 'doc-67'
- - 'doc-68'
- 'doc-69'
- 'doc-7'
- 'doc-70'
- 'doc-71'
- 'doc-72'
- 'doc-73'
- 'doc-74'
- 'doc-75'
- 'doc-76'
- 'doc-77'
- 'doc-78'
- 'doc-79'
- 'doc-8'
- 'doc-9'
- 'public-doc-0'
- - 'public-doc-1'
- 'public-doc-3'
99 changes: 99 additions & 0 deletions ...lts/indirect-lookup-resources-cursored-lookup-resources-for-fred-page-size-5-results.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
---
- - 'doc-93'
- 'doc-94'
- 'doc-95'
- 'doc-96'
- 'doc-97'
- - 'doc-90'
- 'doc-91'
- 'doc-92'
- 'doc-98'
- 'doc-99'
- - 'doc-95'
- 'doc-96'
- 'doc-97'
- 'doc-98'
- 'doc-99'
- - 'doc-0'
- 'doc-1'
- 'doc-10'
- 'doc-11'
- 'doc-12'
- - 'doc-13'
- 'doc-14'
- 'doc-15'
- 'doc-16'
- 'doc-17'
- - 'doc-18'
- 'doc-19'
- 'doc-2'
- 'doc-20'
- 'doc-21'
- - 'doc-22'
- 'doc-23'
- 'doc-24'
- 'doc-25'
- 'doc-26'
- - 'doc-27'
- 'doc-28'
- 'doc-29'
- 'doc-3'
- 'doc-30'
- - 'doc-31'
- 'doc-32'
- 'doc-33'
- 'doc-34'
- 'doc-35'
- - 'doc-36'
- 'doc-37'
- 'doc-38'
- 'doc-39'
- 'doc-4'
- - 'doc-40'
- 'doc-41'
- 'doc-42'
- 'doc-43'
- 'doc-44'
- - 'doc-45'
- 'doc-46'
- 'doc-47'
- 'doc-48'
- 'doc-49'
- - 'doc-5'
- 'doc-50'
- 'doc-51'
- 'doc-52'
- 'doc-53'
- - 'doc-54'
- 'doc-55'
- 'doc-56'
- 'doc-57'
- 'doc-58'
- - 'doc-59'
- 'doc-6'
- 'doc-60'
- 'doc-61'
- 'doc-62'
- - 'doc-63'
- 'doc-64'
- 'doc-65'
- 'doc-66'
- 'doc-67'
- - 'doc-68'
- 'doc-69'
- 'doc-7'
- 'doc-70'
- 'doc-71'
- - 'doc-72'
- 'doc-73'
- 'doc-74'
- 'doc-75'
- 'doc-76'
- - 'doc-77'
- 'doc-78'
- 'doc-79'
- 'doc-8'
- 'doc-9'
- - 'public-doc-0'
- 'public-doc-1'
- 'public-doc-3'
Loading

0 comments on commit 320dae5

Please sign in to comment.