fixes WriteRelationships/BulkImport GRPC error codes on conflicts and retryable errors #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
fix-error-codes-conflict-and-retryable-crdb
branch
2 times, most recently
from
302cd04
to
9eb6f64
Compare
vroldanbet
force-pushed
the
fix-error-codes-conflict-and-retryable-crdb
branch
2 times, most recently
from
d53ed6a
to
edd6162
Compare
vroldanbet
changed the title
vroldanbet
force-pushed
the
fix-error-codes-conflict-and-retryable-crdb
branch
from
edd6162
to
1ebc5a2
Compare
vroldanbet
changed the title
vroldanbet
force-pushed
the
fix-error-codes-conflict-and-retryable-crdb
branch
from
1ebc5a2
to
9630ab3
Compare
vroldanbet
force-pushed
the
fix-error-codes-conflict-and-retryable-crdb
branch
from
9630ab3
to
216da23
Compare
- duplicate relationship now reports gRPC code AlreadyExists - retryable errors now return grpc code Unavailable
vroldanbet
force-pushed
the
fix-error-codes-conflict-and-retryable-crdb
branch
from
216da23
to
46ba52d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built to support authzed/zed#316
Adjusts BulkImport so it returns gRPC codes to let clients know if it's ok to retry.
AlreadyExistsUnavailable