Add batching functionality #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
requested changes
May 13, 2022
bryanhuhta
commented
May 13, 2022
| if _, err := client.WriteRelationships(context.Background(), request); err != nil { | ||
| return err | ||
| } | ||
| err := grpcutil.ConcurrentBatch(context.Background(), len(relationshipUpdates), batchSize, workers, func(ctx context.Context, no int, start int, end int) error { |
There was a problem hiding this comment.
In theory we could use a cancel context here and have another cli flag to dictate how long a timeout should be. I think that should be a follow up feature though.
jzelinskie
reviewed
May 13, 2022
Signed-off-by: Bryan Huhta <[email protected]>
jzelinskie
approved these changes
May 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #95
closes #94
This PR implements a more testable variant of batching than the one presented in #95. The default batch size is 1000 records with 1 worker. A single worker renders the import synchronous, making parallel processing opt-in.