Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LookupSubjects support to zed #149

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Add LookupSubjects support to zed #149

merged 4 commits into from
Sep 13, 2022

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Sep 13, 2022 •
edited
Loading

@josephschorr josephschorr force-pushed the lookup-subjects branch 2 times, most recently from f410454 to 7e1b732 Compare September 13, 2022 16:41
jzelinskie
jzelinskie previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor recommendation for the type splitting code.
This codebase could probably use a nice spring-cleaning for stuff like that, too.

cmd/zed/permission.go Outdated Show resolved Hide resolved
@josephschorr josephschorr merged commit f0f9fbc into authzed:main Sep 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
@josephschorr josephschorr deleted the lookup-subjects branch September 13, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jzelinskie jzelinskie jzelinskie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for lookupsubjects to zed
2 participants
@josephschorr @jzelinskie