Add a flag to have zed exit with code 1 on check failure #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
reviewed
Jun 16, 2023
| @@ -73,6 +74,7 @@ func RegisterPermissionCmd(rootCmd *cobra.Command) *cobra.Command { | |||
| _ = checkCmd.Flags().MarkHidden("revision") | |||
| checkCmd.Flags().Bool("explain", false, "requests debug information from SpiceDB and prints out a trace of the requests") | |||
| checkCmd.Flags().Bool("schema", false, "requests debug information from SpiceDB and prints out the schema used") | |||
| checkCmd.Flags().Bool("error-on-no-permission", false, "if true, zed will return exit code 1 if subject does not have unconditional permission") | |||
There was a problem hiding this comment.
bike shedding but maybe --exit-1-without-membership? I don't really like either
Can we find prior art for a flag like this in other software?
There was a problem hiding this comment.
I did a cursory search but couldn't find anything before I came up with this name randomly. I'm fine with whatever
jzelinskie
approved these changes
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69