Add command for redacting backups #318
Conversation
There was a problem hiding this comment.
LGTM, just a comment
Can we 🙏🏻 merge #316 first? It's had its fair share of rebasing already
| Relations map[string]string | ||
|
|
||
| // ObjectIDs is the map of original object IDs to their redacted names. | ||
| ObjectIDs map[string]string |
There was a problem hiding this comment.
For very large large backupfiles, this may not fit in memory and cause the process to crash. A hash of ObjectIDs could be used, trading off memory for CPU usage, which may make the redaction take longer for large files but at least it wouldn't crash.
There was a problem hiding this comment.
My concern with using a hash is the risk of conflicts
| caveatDef.Name = redactionMap.Caveats[caveatDef.Name] | ||
| } | ||
|
|
||
| // TODO: Redact caveat parameters. |
There was a problem hiding this comment.
zed should show a warning when caveats are used, or fail, otherwise users may falsely assume everything will be redacted, including caveat args.
I lean towards alerting so the user makes their call about it.
josephschorr
force-pushed
the
backup-redact
branch
from
8cba003
to
2c60af9
Compare
Helpful for providing community support without leaking the names, comments and/or object IDs in the permission system
josephschorr
force-pushed
the
backup-redact
branch
from
2c60af9
to
28ee244
Compare
|
Rebased |
Helpful for providing community support without leaking the names, comments and/or object IDs in the permission system
Related: #194