Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI usage with no pre-set context/config #420

Merged
merged 12 commits into from
Sep 19, 2024
Merged

Fix CLI usage with no pre-set context/config #420

merged 12 commits into from
Sep 19, 2024

Commits on Sep 19, 2024

  1. Separate existence concern from fetching concern

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c4a1684 View commit details
    Browse the repository at this point in the history

  2. Add tests that captured behavior

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6953f57 View commit details
    Browse the repository at this point in the history

  3. Use IfExists form

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3f13864 View commit details
    Browse the repository at this point in the history

  4. Add handling for no config case

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c57f1cb View commit details
    Browse the repository at this point in the history

  5. Add existence function for config

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3dfd468 View commit details
    Browse the repository at this point in the history

  6. Finish writing tests

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5b857c3 View commit details
    Browse the repository at this point in the history

  7. Remove test that's hard to isolate

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ddf0f62 View commit details
    Browse the repository at this point in the history

  8. Gofumpt

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ca7c55d View commit details
    Browse the repository at this point in the history

  9. Update comment

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1948291 View commit details
    Browse the repository at this point in the history

  10. Update internal/client/client_test.go 

    Co-authored-by: Evan Cordell <[email protected]>
    @tstirrat15 @ecordell
    tstirrat15 and ecordell authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    75a4c78 View commit details
    Browse the repository at this point in the history

  11. Use errors.is, flatten chain

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    05907d8 View commit details
    Browse the repository at this point in the history

  12. Remove unused value

    @tstirrat15
    tstirrat15 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d7a9a00 View commit details
    Browse the repository at this point in the history