Set Advanced Build Settings / Output / Debugging information to "Full…

[jeanluc33]

For issue 58: #58

Resolve issue with "Indexed source information could not be retrieved from..." on certain TFS servers."

From commit:
…" (has the effect of modying .csproj file to add full for each debug and release configurations.

[alsami]

Can you please squash the commits?

[tillig]

Needs more research. See #58.

[alsami]

@jeanluc33 could you please change the output type to full within the main PropertyGroup, independent of configuration and framework, as described here?

[jeanluc33]

As requested, I can put the debugtype property in the main PropertyGroup, and this will resolve my issue.

We should note for future reference though, that probably multi-targeting is a longer-term solution, as the .pdb format that works for me ("full") may not be preferable for a developer on a different platform (e.g. compiling .net core on an arbitrary platform, say linux, might be beneficial to have "portable" pdb, depending on whatever tooling is available).

But I won't complain, this works for us!

[tillig]

Hang on, we may need to do some more investigation here.

DebugType: full appears to have some impact on the JIT optimized code quality and it's recommended specifically that it's not used for release quality code.

PDB is included here to allow SourceLink to work.

Before we add this, let's see if there's some way we can follow up with the SourceLink team to see if they know what's going on here. I'm not against trying to come up with a fix, but I also want to be sure we're not adding a perf hit to everyone just for this situation.

I'm going to copy/paste this comment back to #58 and autofac/Autofac#995. Let's consolidate the discussion on researching these issues back on autofac/Autofac#995 rather than across this PR and the two issues. It's too hard to keep up.

Until we know what the actual solution is, let's close this PR and implement when we're sure, possibly with an all new PR.