Add DisposeScopeOnAppDisposing to AutofacWebApiAppBuilderExtensions. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [SecuritySafeCritical] | ||
| public static IAppBuilder DisposeScopeOnAppDisposing(this IAppBuilder app, ILifetimeScope lifetimeScope) | ||
| { | ||
| var context = new OwinContext(app.Properties); |
There was a problem hiding this comment.
Check lifetimeScope for null, throw ArgumentNullException
|
This looks awesome. If we can get a null check on |
|
Added checks for both arguments since it is technically possible (though unlikely) to invoke an extension method on a null instance of IAppBuilder. |
|
Rock and roooooooll 🎸 |
tillig
added a commit
that referenced
this pull request
Sep 8, 2015
…p-disposing Add DisposeScopeOnAppDisposing to AutofacWebApiAppBuilderExtensions.
|
I'm realizing as I read this that it probably should be in Autofac.Owin rather than in the Web API specific library. My bad on not seeing that before. When I get this library ready to go for 4.0.0 I may move the method so folks using OWIN but not necessarily Web API can make use of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1.