Fix #1238 - Only consider instance constructors #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillig
commented
Dec 11, 2020
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "dotnet-test-explorer.testProjectPath": "test/**/*Test.csproj", | |||
There was a problem hiding this comment.
This helps avoid showing the benchmark tests in the VS Code test explorer so you can just "run all tests" without having to worry about eating the next 45 minutes with benchmarks.
tillig
commented
Dec 11, 2020
| @@ -41,5 +42,176 @@ public void AnOpenGenericTypeIsNotAClosedTypeOfAnything() | |||
| { | |||
| Assert.False(typeof(CommandBase<>).IsClosedTypeOf(typeof(CommandBase<>))); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We didn't really have any test coverage specifically around these extensions so I added it to ensure the update to the constructor search flags didn't break anything else.
Codecov Report
@@ Coverage Diff @@
## develop #1239 +/- ##
========================================
Coverage 27.77% 27.77%
========================================
Files 11 11
Lines 18 18
Branches 1 1
========================================
Hits 5 5
Misses 12 12
Partials 1 1 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1238 shows that when we query types for constructors, usually when building reflection activators, we're inadvertently getting static constructors along with instance constructors. Since we can't create an instance of a type based on a static constructor, this PR removes the
BindingFlags.Staticwhen searching for constructors.