Move WithMetadata with mapping for OpenGenericAssemblyScanning

[romerod]

Add support for adding metadata accepting a type to metadata mapper.

[codecov]

Codecov Report

Merging #1299 (e8e2dd5) into develop (a6a4d8d) will decrease coverage by 0.04%.
The diff coverage is 92.30%.

❗ Current head e8e2dd5 differs from pull request most recent head be6efa3. Consider uploading reports for the commit be6efa3 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1299      +/-   ##
===========================================
- Coverage    76.62%   76.57%   -0.05%     
===========================================
  Files          188      188              
  Lines         5181     5183       +2     
  Branches      1061     1062       +1     
===========================================
- Hits          3970     3969       -1     
- Misses         712      714       +2     
- Partials       499      500       +1     

Impacted Files	Coverage Δ
...nning/OpenGenericScanningRegistrationExtensions.cs	84.33% <ø> (-3.40%)	⬇️
...istrationExtensions.OpenGenericAssemblyScanning.cs	76.81% <92.00%> (+8.62%)	⬆️
.../Core/Resolving/Pipeline/ResolvePipelineBuilder.cs	93.50% <100.00%> (+0.64%)	⬆️
src/Autofac/Util/SequenceGenerator.cs	71.42% <0.00%> (-28.58%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a4d8d...be6efa3. Read the comment docs.

[tillig]

I think this looks good. I'm not sure why it was internal to start - we have a test for it to verify it works, but it was working due to access to internals. Before I approve - @alistairjevans @RaymondHuy do you guys know if there was a specific reason this was internal or was it just an oversight?

[alistairjevans]

Looks like it was just an oversight; the tests for it clearly believe it to be publicly accessible. @romerod, can you also move the WithMetadataFrom method below it, which I suspect fell foul of the same problem?

[RaymondHuy]

@tillig yes, it's my mistake, I'm sorry about it.

[romerod]

OK, i'll move the other method on monday. Thanks for the review. Holen Sie sich Outlook für Android<https://aka.ms/AAb9ysg>

…

________________________________ From: RaymondHuy ***@***.***> Sent: Friday, December 10, 2021 10:09:48 AM To: autofac/Autofac ***@***.***> Cc: Daniel Romero ***@***.***>; Mention ***@***.***> Subject: Re: [autofac/Autofac] Add WithMetadata with mapping for OpenGenericAssemblyScanning (PR #1299) @tillig<https://github.com/tillig> yes, it's my mistake, I'm sorry about it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1299 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYQTXU6UMMGCBWEM6RM27TUQG7VZANCNFSM5JWV7XUQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[tillig]

LGTM! Thanks!