Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum range in exception message raised when an invalid phase is used for registration middleware. #1302

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

alistairjevans
Copy link
Member

Fixes #1301 by making sure the right message is raised

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #1302 (41dfaac) into develop (a6a4d8d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1302      +/-   ##
===========================================
- Coverage    76.62%   76.60%   -0.02%     
===========================================
  Files          188      188              
  Lines         5181     5181              
  Branches      1061     1061              
===========================================
- Hits          3970     3969       -1     
- Misses         712      713       +1     
  Partials       499      499              
Impacted Files Coverage Δ
.../Core/Resolving/Pipeline/ResolvePipelineBuilder.cs 93.50% <100.00%> (+0.64%) ⬆️
src/Autofac/Util/SequenceGenerator.cs 71.42% <0.00%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a4d8d...41dfaac. Read the comment docs.

Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tillig tillig merged commit e9a37e5 into autofac:develop Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a middleware throws an System.InvalidOperationException: 'Cannot add service middleware in phase....'
2 participants