Update build/target frameworks for .NET 8; remove netcoreapp3.1. #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, this was "change a private method to return the concrete type instead of an interface." This seemed reasonable and not breaking.
dotnet/docs#34893 .NET has long been deprecating BinaryFormatter and Serializable items. Analyzers as of .NET 8 are warning about obsolete serialization constructors. Given most of the underpinnings of this mechanism are also being deprecated, it seemed reasonable to include deprecation for that in Autofac. For projects that continue to use AppDomains and need to serialize exceptions over the wire, it's recommended to not upgrade Autofac to this version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1401 +/- ##
===========================================
- Coverage 78.47% 78.46% -0.02%
===========================================
Files 201 200 -1
Lines 5715 5702 -13
Branches 1169 1168 -1
===========================================
- Hits 4485 4474 -11
+ Misses 716 714 -2
Partials 514 514 ☔ View full report in Codecov by Sentry. |
alistairjevans
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Did you want to do the major version bump in here, since we'll merge #1397 as well before release?
|
Good point; there's also breaking change due to the exception serialization thing. I'll add that. |
alistairjevans
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the build to use .NET 8 and adds targeting for .NET 8 on all assemblies.
DependencyResolutionException. .NET has been steadily working on deprecating binary serialization and as of .NET 8 things are getting caught by both[Obsolete]warnings and Roslyn analyzers telling you it's time to move. This both keeps Autofac in line with the trend toward serialization removal and reduces support overhead. People are urged to move away from binary serialization where possible; and where not, it's up to development teams to start creating mechanisms to marshal dependency resolution issues across the wire.