-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization: Memoize RequiredMemberAttribute
search
#1415
Conversation
I see this will not work because of "Unloading feature" |
We have all of the reflection-related caches centralized to allow for unloading assembly load contexts. I'm guessing that's why some of those tests are failing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1415 +/- ##
===========================================
+ Coverage 78.48% 78.52% +0.03%
===========================================
Files 200 200
Lines 5703 5713 +10
Branches 1168 1168
===========================================
+ Hits 4476 4486 +10
Misses 714 714
Partials 513 513 ☔ View full report in Codecov by Sentry. |
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Will hold on releasing publicly until we figure out #1414, but you can do a comparison using the MyGet feed https://www.myget.org/F/autofac/api/v3/index.json
- a -beta
should show up there based on the build here.
We see in Profiler that
.GetCustomAttribute()
is a hotspot.Memoizing it will improve performance.