Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10, drop python 3.7 #29

Merged
merged 7 commits into from
Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflow_scripts/test_cloud.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ set -ex

source $(dirname "$0")/env_setup.sh

install_cloud_test

if [ $MODULE = "tabular" ]
then
install_tabular $AG_VERSION
Expand All @@ -15,6 +17,4 @@ then
install_multimodal $AG_VERSION
fi

install_cloud_test

python3 -m pytest -n 2 --junitxml=results.xml tests/unittests/$MODULE/ --framework_version $AG_VERSION
24 changes: 12 additions & 12 deletions .github/workflows/continuous_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
ref: "refs/pull/${{ github.event.number }}/merge"
- uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.10'
- name: Check if changes beside docs
uses: dorny/paths-filter@v2
id: changes
Expand All @@ -65,7 +65,7 @@ jobs:
test_general_cloud:
strategy:
matrix:
AG_VERSION: ["source", "0.6.2"]
AG_VERSION: ["source", "0.7.0"]
needs: cloud_lint_check
runs-on: ubuntu-latest
steps:
Expand All @@ -79,7 +79,7 @@ jobs:
ref: "refs/pull/${{ github.event.number }}/merge"
- uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.10'
- name: Check if changes beside docs
uses: dorny/paths-filter@v2
id: changes
Expand All @@ -96,7 +96,7 @@ jobs:
test_tabular_cloud:
strategy:
matrix:
AG_VERSION: ["source", "0.6.2"]
AG_VERSION: ["source", "0.7.0"]
needs: cloud_lint_check
runs-on: ubuntu-latest
steps:
Expand All @@ -110,7 +110,7 @@ jobs:
ref: "refs/pull/${{ github.event.number }}/merge"
- uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.10'
- name: Check if changes beside docs
uses: dorny/paths-filter@v2
id: changes
Expand All @@ -127,7 +127,7 @@ jobs:
test_text_cloud:
strategy:
matrix:
AG_VERSION: ["source", "0.6.2"]
AG_VERSION: ["source", "0.7.0"]
needs: cloud_lint_check
runs-on: ubuntu-latest
steps:
Expand All @@ -141,7 +141,7 @@ jobs:
ref: "refs/pull/${{ github.event.number }}/merge"
- uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.10'
- name: Check if changes beside docs
uses: dorny/paths-filter@v2
id: changes
Expand All @@ -158,7 +158,7 @@ jobs:
test_image_cloud:
strategy:
matrix:
AG_VERSION: ["source", "0.6.2"]
AG_VERSION: ["source", "0.7.0"]
needs: cloud_lint_check
runs-on: ubuntu-latest
steps:
Expand All @@ -172,7 +172,7 @@ jobs:
ref: "refs/pull/${{ github.event.number }}/merge"
- uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.10'
- name: Check if changes beside docs
uses: dorny/paths-filter@v2
id: changes
Expand All @@ -189,7 +189,7 @@ jobs:
test_multimodal_cloud:
strategy:
matrix:
AG_VERSION: ["source", "0.6.2"]
AG_VERSION: ["source", "0.7.0"]
needs: cloud_lint_check
runs-on: ubuntu-latest
steps:
Expand All @@ -203,7 +203,7 @@ jobs:
ref: "refs/pull/${{ github.event.number }}/merge"
- uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.10'
- name: Check if changes beside docs
uses: dorny/paths-filter@v2
id: changes
Expand All @@ -220,7 +220,7 @@ jobs:
test_timeseries_cloud:
strategy:
matrix:
AG_VERSION: ["source", "0.6.2"]
AG_VERSION: ["source", "0.7.0"]
needs: cloud_lint_check
runs-on: ubuntu-latest
steps:
Expand Down
5 changes: 2 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
AUTOGLUON = "autogluon"
CLOUD = "cloud"

PYTHON_REQUIRES = ">=3.7, <3.10"
PYTHON_REQUIRES = ">=3.8, <3.11"


def create_version_file(*, version):
Expand Down Expand Up @@ -107,8 +107,7 @@ def default_setup_args(*, version):

install_requires = [
# common module provides utils with stable api across minor version
# TODO: update to 0.7 when 0.7 dlc container available in sagemaker
"autogluon.common>=0.6,<1.0",
"autogluon.common>=0.7,<1.0",
# <2 because unlikely to introduce breaking changes in minor releases. >=1.10 because 1.10 is 3 years old, no need to support older
"boto3>=1.10,<2.0",
"numpy>=1.21,<1.27",
Expand Down
4 changes: 3 additions & 1 deletion tests/unittests/tabular/test_tabular.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def test_tabular_tabular_text_image(test_helper, framework_version):
custom_image_uri=inference_custom_image_uri,
),
)
local_predictor = cloud_predictor.to_local_predictor(require_version_match=False)
local_predictor = cloud_predictor.to_local_predictor(
require_version_match=False, require_py_version_match=False
)
models = local_predictor.get_model_names()
assert "ImagePredictor" in models