Update Web Style #62
Update Web Style #62
Conversation
|
Job PR-62-5ade0c3 is done. |
|
Job PR-62-b4a244c is done. |
|
Job PR-62-8161e66 is done. |
|
|
||
| googleanalytics_id = "UA-96378503-20" | ||
|
|
||
| nb_execution_mode = 'force' |
There was a problem hiding this comment.
You can set this to off while you don't have any notebooks that need to be executed.
There was a problem hiding this comment.
I think we can leave it as is cause it's possible that we will want to execute some content in the future, and it would be confusing for someone unfamiliar with this to know how to enable execution
| nb_dirs_to_exec = [os.path.join('tutorials', tag) for tag in tags if os.path.isdir(os.path.join('tutorials', tag))] | ||
|
|
||
| if len(nb_dirs_to_exec) > 0: | ||
| nb_dirs_to_exclude = [dirpath for dirpath, _, filenames in os.walk('tutorials') | ||
| if any(map(lambda x: x.endswith('.ipynb'), filenames)) | ||
| and not dirpath.startswith(tuple(nb_dirs_to_exec))] | ||
|
|
||
| for nb_dir in nb_dirs_to_exclude: | ||
| nb_execution_excludepatterns.append(os.path.join(nb_dir, '*.ipynb')) |
There was a problem hiding this comment.
If you don't need the ability to exclude building some notebooks, I like the idea of getting rid of these lines because they take extra time to understand.
There was a problem hiding this comment.
I think this is a nice feature and could be useful in the future so I left it here
| @@ -650,6 +650,7 @@ def predict_proba( | |||
| return self.backend.predict_proba( | |||
| test_data=test_data, | |||
| test_data_image_column=test_data_image_column, | |||
| include_predict=include_predict, | |||
There was a problem hiding this comment.
Just curious, where did this come from?
There was a problem hiding this comment.
I just noticed this variable is not being passed in after the backend update so decided to add it here
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.