-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page title for app authorization #2100
Fix page title for app authorization #2100
Conversation
(cherry picked from commit 0e70986)
WalkthroughThe change addresses a syntax error in a Ruby on Rails view file related to the Doorkeeper gem, which is used for OAuth 2.0 authorization. Specifically, it corrects the way a variable ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the catch!
2186b48
to
25bff1a
Compare
25bff1a
to
6e0c41f
Compare
6e0c41f
to
c172b9e
Compare
c172b9e
to
9c4ef38
Compare
Sorry for the delay - one of the checks was getting stuck so I've disabled it for now |
This fixes a string templating error, so the value of the variable is properly displayed in the page title now.
Description
Before:
After:
Motivation and Context
I saw that the page title wasn't set correctly while authorizing an OAuth app.
How Has This Been Tested?
Just looking at the tab.
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting