Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page title for app authorization #2100

Conversation

NicholasMy
Copy link
Contributor

This fixes a string templating error, so the value of the variable is properly displayed in the page title now.

Description

Before:

image

After:
image

Motivation and Context

I saw that the page title wasn't set correctly while authorizing an OAuth app.

How Has This Been Tested?

Just looking at the tab.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

(cherry picked from commit 0e70986)
Copy link
Contributor

coderabbitai bot commented Feb 20, 2024

Walkthrough

The change addresses a syntax error in a Ruby on Rails view file related to the Doorkeeper gem, which is used for OAuth 2.0 authorization. Specifically, it corrects the way a variable (@pre_auth.client.name) is interpolated into a string. By adding curly braces around the variable, the fix ensures that the client's name is properly displayed in the user interface, enhancing both the functionality and the user experience of the authorization process.

Changes

File Summary
app/views/doorkeeper/authorizations/new.html.erb Fixed syntax error by adding curly braces for variable interpolation in the title.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@gitstream-cm gitstream-cm bot requested review from a team and evanyeyeye and removed request for a team February 20, 2024 16:38
@gitstream-cm gitstream-cm bot added small Pull request is small waiting-for-review labels Feb 20, 2024
Copy link
Member

@evanyeyeye evanyeyeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the catch!

@evanyeyeye evanyeyeye force-pushed the oauth-app-authorization-title-fix-nicholasmy branch from 2186b48 to 25bff1a Compare February 21, 2024 05:44
@damianhxy damianhxy added small Pull request is small and removed small Pull request is small labels Feb 21, 2024
@evanyeyeye evanyeyeye force-pushed the oauth-app-authorization-title-fix-nicholasmy branch from 25bff1a to 6e0c41f Compare February 21, 2024 20:55
@damianhxy damianhxy force-pushed the oauth-app-authorization-title-fix-nicholasmy branch from 6e0c41f to c172b9e Compare February 22, 2024 01:05
@damianhxy damianhxy force-pushed the oauth-app-authorization-title-fix-nicholasmy branch from c172b9e to 9c4ef38 Compare February 22, 2024 01:09
@damianhxy damianhxy added this pull request to the merge queue Feb 22, 2024
@damianhxy
Copy link
Member

Sorry for the delay - one of the checks was getting stuck so I've disabled it for now

Merged via the queue into autolab:master with commit 4bffdb4 Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants