-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow instructors to be included on scoreboards #2101
Allow instructors to be included on scoreboards #2101
Conversation
WalkthroughWalkthroughThe recent updates aim to enhance the functionality of scoreboards by enabling the inclusion of instructors in the display based on a new setting. These changes span across the controller, view files, and database schema. A migration introduces a new boolean column to support this feature, while the user interface is updated to provide control over this setting. Additionally, improvements in the view files enhance usability and presentation. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Made a few design modifications.
This allows instructors to choose to include themselves and CAs on assessment scoreboards if they want, on a per-scoreboard basis.
Description
Instructors can check the box to include instructors on scoreboards on the "scoreboard settings page." If this is checked, instructors and CAs will be included in the scoreboard.
Motivation and Context
Professors want to compete with their students. A very old version of Autolab included everybody by default. There was an update that removed instructors. Some instructors want to be included, while others don't. Now they can choose.
How Has This Been Tested?
I created a couple scoreboards, verified instructors aren't included by default, checked the checkbox, verified instructors are now included on the scoreboard, unchecked the checkbox, verified instructors disappeared from the scoreboard.
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting