-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a button to show students with missing submissions #2105
Conversation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
WalkthroughWalkthroughThe update introduces functionality to manage the release of student grades in assessments, including toggling the display of missing submissions on the gradesheet as a configurable option. This encompasses backend changes for grade management, helper methods for release status checks, frontend modifications for user interaction with grades visibility, and routing adjustments to support these actions. The changes aim to enhance instructor control over grade visibility and streamline the grading process by addressing specific user feedback. Changes
Assessment against linked issues
The changes directly address the primary objective outlined in issue #2080 by implementing a toggleable option for displaying missing submissions on the gradesheet. This is achieved through modifications in the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Note: for the "How Has This Been Tested?" portion of the PR you should outline the specific steps you took to test the new behavior (and also how you want your reviewer to test the PR, taking note to what the reviewer should be looking for) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally this works, but I would like to see some changes to how you're implementing them to be more rails-like, using params and also jquery instead of url manipulation. Let me know if you need help / have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner! LGTM :))
Description
Screenshots:
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for lintingOther issues / help required
If unsure, feel free to submit first and we'll help you along.