Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility for svn yaml field #2106

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

evanyeyeye
Copy link
Member

Description

  • has_svn field is now removed from yaml configurations
  • Fixed typo in assessment.rb

Motivation and Context

Due to #2078, importing an existing course (made before the deprecation of has_svn) would cause an error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

coderabbitai bot commented Feb 24, 2024

Walkthrough

Walkthrough

The update introduces a new key has_svn to the compatibility hash and fixes a typo in the hash's name within the assessment.rb model. This adjustment ensures the model's backward compatibility logic accurately reflects the intended spelling and incorporates the new has_svn key, aligning with efforts to manage SVN-related features or legacy code.

Changes

File Path Change Summary
app/models/assessment.rb Added has_svn key to BACKWARDS_COMPATIBILITY and fixed typo in hash name.

Related issues

  • Remove obsolete SVN code #2067: This PR could be linked because it directly addresses the management of has_svn within the model, which is relevant to the issue's objective of removing obsolete SVN code. The addition of has_svn to the BACKWARDS_COMPATIBILITY hash suggests an ongoing transition or cleanup related to SVN features, aligning with the issue's aim to streamline the codebase by removing SVN-related elements.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evanyeyeye evanyeyeye added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@evanyeyeye evanyeyeye added this pull request to the merge queue Feb 26, 2024
Merged via the queue into master with commit c96a549 Feb 26, 2024
5 checks passed
@evanyeyeye evanyeyeye deleted the remove-svn-yaml-fix branch February 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants