Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #249

Merged
Merged

Commits on Jun 4, 2021

  1. Update implementation

    ArlindKadra committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    a7a94e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Coding style fixes

    ArlindKadra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3b7f559 View commit details
    Browse the repository at this point in the history
  2. Implementation update

    ArlindKadra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    11e7021 View commit details
    Browse the repository at this point in the history
  3. Style fix

    ArlindKadra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    375c055 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Configuration menu
    Copy the full SHA
    3413bc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Cocktail branch inconsistencies (#275)

    * To nemo
    
    * Revert change in T_curr as results conclusively prove it should be 0
    
    * Revert cutmix change after data from run
    
    * Final conclusion after results
    
    * FIX bug in shake alpha beta
    
    * Updated if is_training condition for shake drop
    
    * Remove temp fix in row cutmic
    ravinkohli authored Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d37d4a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Cocktail fixes time debug (#286)

    * preprocess inside data validator
    
    * add time debug statements
    
    * Add fixes for categorical data
    
    * add fit_ensemble
    
    * add arlind fix for swa and se
    
    * fix bug in trainer choice fit
    
    * fix ensemble bug
    
    * Correct bug in cleanup
    
    * Cleanup for removing time debug statements
    
    * ablation for adversarial
    
    * shuffle false in dataloader
    
    * drop last false in dataloader
    
    * fix bug for validation set, and cutout and cutmix
    
    * shuffle = False
    
    * Shake Shake updates (#287)
    
    * To test locally
    
    * fix bug in trainer choice fit
    
    * fix ensemble bug
    
    * Correct bug in cleanup
    
    * To test locally
    
    * Cleanup for removing time debug statements
    
    * ablation for adversarial
    
    * shuffle false in dataloader
    
    * drop last false in dataloader
    
    * fix bug for validation set, and cutout and cutmix
    
    * To test locally
    
    * shuffle = False
    
    * To test locally
    
    * updates to search space
    
    * updates to search space
    
    * update branch with search space
    
    * undo search space update
    
    * fix bug in shake shake flag
    
    * limit to shake-even
    
    * restrict to even even
    
    * Add even even and others for shake-drop also
    
    * fix bug in passing alpha beta method
    
    * restrict to only even even
    
    * fix silly bug:
    
    * remove imputer and ordinal encoder for categorical transformer in feature validator
    
    * Address comments from shuhei
    
    * fix issues with ensemble fitting post hoc
    
    * Address comments on the PR
    
    * Fix flake and mypy errors
    
    * Address comments from PR #286
    
    * fix bug in embedding
    
    * Update autoPyTorch/api/tabular_classification.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/datasets/base_dataset.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/datasets/base_dataset.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/pipeline/components/training/trainer/base_trainer.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Address comments from shuhei
    
    * adress comments from shuhei
    
    * fix flake and mypy
    
    * Update autoPyTorch/pipeline/components/training/trainer/RowCutMixTrainer.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/pipeline/tabular_classification.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/pipeline/components/setup/network_backbone/utils.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/pipeline/components/setup/network_backbone/utils.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/pipeline/components/setup/network_backbone/utils.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Apply suggestions from code review
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * increase threads_per_worker
    
    * fix bug in rowcutmix
    
    * Enhancement for the tabular validator. (#291)
    
    * Initial try at an enhancement for the tabular validator
    
    * Adding a few type annotations
    
    * Fixing bugs in implementation
    
    * Adding wrongly deleted code part during rebase
    
    * Fix bug in _get_args
    
    * Fix bug in _get_args
    
    * Addressing Shuhei's comments
    
    * Address Shuhei's comments
    
    * Refactoring code
    
    * Refactoring code
    
    * Typos fix and additional comments
    
    * Replace nan in categoricals with simple imputer
    
    * Remove unused function
    
    * add comment
    
    * Update autoPyTorch/data/tabular_feature_validator.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Update autoPyTorch/data/tabular_feature_validator.py
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Adding unit test for only nall columns in the tabular feature categorical evaluator
    
    * fix bug in remove all nan columns
    
    * Bug fix for making tests run by arlind
    
    * fix flake errors in feature validator
    
    * made typing code uniform
    
    * Apply suggestions from code review
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * address comments from shuhei
    
    * address comments from shuhei (2)
    
    Co-authored-by: Ravin Kohli <[email protected]>
    Co-authored-by: Ravin Kohli <[email protected]>
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * Apply suggestions from code review
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * resolve code issues with new versions
    
    * Address comments from shuhei
    
    * make run_traditional_ml function
    
    * implement suggestion from shuhei and fix bug in rowcutmixtrainer
    
    * fix return type docstring
    
    * add better documentation and fix bug in shake_drop_get_bl
    
    * Apply suggestions from code review
    
    Co-authored-by: nabenabe0928 <[email protected]>
    
    * add test for comparator and other improvements based on PR comments
    
    * fix bug in test
    
    * [fix] Fix the condition in the raising error of all_nan_columns
    
    * [refactor] Unite name conventions of numpy array and pandas dataframe
    
    * [doc] Add the description about the tabular feature transformation
    
    * [doc] Add the description of the tabular feature transformation
    
    * address comments from arlind
    
    * address comments from arlind
    
    * change to as_tensor and address comments from arlind
    
    * correct description for functions in data module
    
    Co-authored-by: nabenabe0928 <[email protected]>
    Co-authored-by: Arlind Kadra <[email protected]>
    Co-authored-by: nabenabe0928 <[email protected]>
    4 people authored Oct 20, 2021
    Configuration menu
    Copy the full SHA
    23466f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    00f80cb View commit details
    Browse the repository at this point in the history
  3. flake8 problems fix

    ArlindKadra committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    88e0228 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Update autoPyTorch/api/base_task.py

    Add indent.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    3b6ec03 View commit details
    Browse the repository at this point in the history
  2. Update autoPyTorch/api/base_task.py

    Add indent.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    a26edbe View commit details
    Browse the repository at this point in the history
  3. Update autoPyTorch/data/tabular_feature_validator.py

    Add indentation.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    73a11c9 View commit details
    Browse the repository at this point in the history
  4. Update autoPyTorch/pipeline/components/setup/network_backbone/utils.py

    Add line indentation.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    37e3537 View commit details
    Browse the repository at this point in the history
  5. Update autoPyTorch/data/tabular_feature_validator.py

    Validate if there is a column transformer since for sparse matrices we will not have one.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    dc5e8a2 View commit details
    Browse the repository at this point in the history
  6. Update autoPyTorch/utils/implementations.py

    Delete uncommented line.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    48b16a3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dab2f76 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6f0aecb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    84d7406 View commit details
    Browse the repository at this point in the history
  10. Update autoPyTorch/pipeline/components/setup/network_backbone/utils.py

    Updating the function documentation according to the agreed style.
    
    Co-authored-by: Ravin Kohli <[email protected]>
    ArlindKadra and ravinkohli authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    9f8ebb5 View commit details
    Browse the repository at this point in the history
  11. Update autoPyTorch/pipeline/components/setup/network_backbone/utils.py

    Providing information on the wrong method provided for shake-shake regularization.
    
    Co-authored-by: nabenabe0928 <[email protected]>
    ArlindKadra and nabenabe0928 authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    1488978 View commit details
    Browse the repository at this point in the history
  12. 2 Configuration menu
    Copy the full SHA
    a044a19 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6c8a55b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e9dfea9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    88893a9 View commit details
    Browse the repository at this point in the history
  16. Update autoPyTorch/pipeline/components/setup/network_backbone/ResNetB…

    …ackbone.py
    
    
    Improving code readibility.
    
    Co-authored-by: nabenabe0928 <[email protected]>
    ArlindKadra and nabenabe0928 authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    da6e47c View commit details
    Browse the repository at this point in the history
  17. Update autoPyTorch/pipeline/components/setup/network_backbone/ResNetB…

    …ackbone.py
    
    
    Improving consistency.
    
    Co-authored-by: nabenabe0928 <[email protected]>
    ArlindKadra and nabenabe0928 authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    2740052 View commit details
    Browse the repository at this point in the history
  18. bug fix

    ArlindKadra committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    e597951 View commit details
    Browse the repository at this point in the history