Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes for v0.1.0 #341

Merged
merged 10 commits into from
Nov 23, 2021
Merged

Final changes for v0.1.0 #341

merged 10 commits into from
Nov 23, 2021

Conversation

ravinkohli
Copy link
Contributor

@ravinkohli ravinkohli commented Nov 22, 2021

This PR includes changes from

  1. [enhance] Increase the coverage #336- increases the coverage of the tests to autoPyTorchComponent and autoPyTorchChoice
  2. [feat] Support statistics print by adding results manager object #334- introduces functionality to print search statistics as well as a ResultManager to parse results from api.run_history.
  3. [FIX] Incorrect cost for crash, r2 #340- fixes a bug which causes crashed runs to be preferred over successful runs when using r2.
  4. [FIX] Silence catboost #338- sets verbose=False in catboost.fit().
  5. [doc] Add the workflow of the Auto-Pytorch #285- adds workflow of AutoPyTorch to the README.md file.
  6. [feat] Add an issue template and a PR template #136- adds issue and PR templates.
  7. Update for release #335- updates README.md with a minimal example, updates setup.py and adds release.yml github action to publish tagged commits to PyPI.
  8. [FIX formatting in docs #342

nabenabe0928 and others added 7 commits November 21, 2021 09:43
* [feat] Support statistics print by adding results manager object

* [refactor] Make SearchResults extract run_history at __init__

Since the search results should not be kept in eternally,
I made this class to take run_history in __init__ so that
we can implicitly call extraction inside.
From this change, the call of extraction from outside is not recommended.
However, you can still call it from outside and to prevent mixup of
the environment, self.clear() will be called.

* [fix] Separate those changes into PR#336

* [fix] Fix so that test_loss includes all the metrics

* [enhance] Strengthen the test for sprint and SearchResults

* [fix] Fix an issue in documentation

* [enhance] Increase the coverage

* [refactor] Separate the test for results_manager to organize the structure

* [test] Add the test for get_incumbent_Result

* [test] Remove the previous test_get_incumbent and see the coverage

* [fix] [test] Fix reversion of metric and strengthen the test cases

* [fix] Fix flake8 issues and increase coverage

* [fix] Address Ravin's comments

* [enhance] Increase the coverage

* [fix] Fix a flake8 issu
* Create release workflow and CITATION.cff  and update README, setup.py

* fix bug in pypy token

* fix documentation formatting

* TODO for docker image

* accept suggestions from shuhei

* add further options for disable_file_output documentation

* remove  from release.yml
* [doc] Add workflow of the AutoPytorch

* [doc] Address Ravin's comment
* set verbose=False in catboost

* fix flake
README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #341 (ef8d21a) into master (a1512d5) will increase coverage by 0.28%.
The diff coverage is 97.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   81.82%   82.11%   +0.28%     
==========================================
  Files         152      153       +1     
  Lines        8677     8812     +135     
  Branches     1325     1341      +16     
==========================================
+ Hits         7100     7236     +136     
+ Misses       1111     1107       -4     
- Partials      466      469       +3     
Impacted Files Coverage Δ
autoPyTorch/api/tabular_classification.py 87.50% <ø> (ø)
autoPyTorch/api/tabular_regression.py 96.87% <ø> (ø)
...ch/pipeline/components/training/metrics/metrics.py 100.00% <ø> (ø)
setup.py 0.00% <ø> (ø)
autoPyTorch/api/base_task.py 83.23% <93.54%> (-1.41%) ⬇️
autoPyTorch/api/results_manager.py 98.37% <98.37%> (ø)
autoPyTorch/evaluation/abstract_evaluator.py 76.14% <100.00%> (+0.14%) ⬆️
...tup/traditional_ml/traditional_learner/learners.py 83.09% <100.00%> (ø)
...peline/components/training/trainer/base_trainer.py 95.76% <0.00%> (-1.06%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1512d5...ef8d21a. Read the comment docs.

* fix formatting in docs

* Update examples/40_advanced/example_resampling_strategy.py
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly okay, just one comment on the install requirements and a stray file from testing.

README.md Show resolved Hide resolved
test/test_api/.tmp_api/runhistory_B.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ravinkohli ravinkohli merged commit e4863fe into master Nov 23, 2021
github-actions bot pushed a commit that referenced this pull request Nov 23, 2021
@atifrizwan91
Copy link

Hello, I'm facing an error while running example_visualization.py with the message

"TypeError: init() got an unexpected keyword argument 'multi_objectives' "

@ravinkohli
Copy link
Contributor Author

@atifrizwan91 Could you create an issue and explain your environment as well as the version of AutoPyTorch you are using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants