Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Tests after rebase of reg_cocktails #359

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

ravinkohli
Copy link
Contributor

@ravinkohli ravinkohli commented Dec 8, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Note that a Pull Request should only contain one of refactoring, new features or documentation changes.
Please separate these changes and send us individual PRs for each.
For more information on how to create a good pull request, please refer to The anatomy of a perfect pull request.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

This PR resolves the leftover conflicts following the rebase of reg_cocktails with development. It also fixes the failing tests and resolves other incompatibilities between the refactor_development_regularization_cocktails and `development.

Motivation and Context

It solves the bugs in reg_cocktails so it can pass its checks.

How has this been tested?

Not relevant as no new feature has been added.

@ravinkohli ravinkohli changed the title update requirements [FIX] Tests after rebase of reg_cocktails Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (reg_cocktails@87ee242). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             reg_cocktails     #359   +/-   ##
================================================
  Coverage                 ?   81.48%           
================================================
  Files                    ?      164           
  Lines                    ?     9917           
  Branches                 ?     1759           
================================================
  Hits                     ?     8081           
  Misses                   ?     1294           
  Partials                 ?      542           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ee242...bc535dc. Read the comment docs.

@ravinkohli ravinkohli merged commit 33b2223 into reg_cocktails Dec 10, 2021
ravinkohli added a commit that referenced this pull request Dec 21, 2021
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
ravinkohli added a commit that referenced this pull request Jan 24, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
ravinkohli added a commit that referenced this pull request Jan 28, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
ravinkohli added a commit that referenced this pull request Feb 28, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
ravinkohli added a commit that referenced this pull request Feb 28, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
ravinkohli added a commit that referenced this pull request Mar 9, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
ravinkohli added a commit to ravinkohli/Auto-PyTorch that referenced this pull request Apr 12, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
@ravinkohli ravinkohli deleted the reg_cocktails_fix_tests branch June 15, 2022 13:15
ravinkohli added a commit that referenced this pull request Jul 26, 2022
* update requirements

* update requirements

* resolve remaining conflicts and fix flake and mypy

* Fix remaining tests and examples

* fix failing checks

* fix flake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant