Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reg cocktails common paper modifications 5 #418

Conversation

ravinkohli
Copy link
Contributor

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Note that a Pull Request should only contain one of refactoring, new features or documentation changes.
Please separate these changes and send us individual PRs for each.
For more information on how to create a good pull request, please refer to The anatomy of a perfect pull request.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Motivation and Context

How has this been tested?

@ravinkohli ravinkohli changed the base branch from reg_cocktails-common_paper_modifications_3 to reg_cocktails-common_paper_modifications_2 March 14, 2022 02:25
@ravinkohli ravinkohli merged commit 33d1ac2 into reg_cocktails-common_paper_modifications_2 Mar 14, 2022
ravinkohli added a commit that referenced this pull request Mar 14, 2022
* remove remaining differences

* Reg cocktails common paper modifications 5 (#418)

* add hasttr

* fix run summary
@ravinkohli ravinkohli deleted the reg_cocktails-common_paper_modifications_5 branch March 14, 2022 23:20
ravinkohli added a commit that referenced this pull request Aug 16, 2022
* remove remaining differences

* Reg cocktails common paper modifications 5 (#418)

* add hasttr

* fix run summary
ravinkohli added a commit that referenced this pull request Oct 25, 2022
* remove remaining differences

* Reg cocktails common paper modifications 5 (#418)

* add hasttr

* fix run summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant