Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reg cocktails apt1.0+reg cocktails pytorch embedding reduced #454

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Reg cocktails apt1.0+reg cocktails pytorch embedding reduced #454

merged 3 commits into from
Jul 21, 2022

Conversation

ravinkohli
Copy link
Contributor

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Note that a Pull Request should only contain one of refactoring, new features or documentation changes.
Please separate these changes and send us individual PRs for each.
For more information on how to create a good pull request, please refer to The anatomy of a perfect pull request.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Motivation and Context

How has this been tested?

@ravinkohli ravinkohli force-pushed the reg_cocktails_apt1.0+reg_cocktails_pytorch_embedding_reduced branch from c27c76d to 26c889c Compare July 21, 2022 08:27
@ravinkohli ravinkohli merged commit 3761b53 into reg_cocktails-pytorch_embedding Jul 21, 2022
@ravinkohli ravinkohli deleted the reg_cocktails_apt1.0+reg_cocktails_pytorch_embedding_reduced branch July 21, 2022 08:30
ravinkohli added a commit that referenced this pull request Aug 17, 2022
@ravinkohli
Reg cocktails apt1.0+reg cocktails pytorch embedding reduced (#454)
8e15eec 
* reduce number of hyperparameters for pytorch embedding

* remove todos for the preprocessing PR, and apply suggestion from code review

* remove unwanted exclude in test
@ravinkohli ravinkohli restored the reg_cocktails_apt1.0+reg_cocktails_pytorch_embedding_reduced branch August 17, 2022 18:09
ravinkohli added a commit that referenced this pull request Oct 25, 2022
@ravinkohli
Reg cocktails apt1.0+reg cocktails pytorch embedding reduced (#454)
895b904 
* reduce number of hyperparameters for pytorch embedding

* remove todos for the preprocessing PR, and apply suggestion from code review

* remove unwanted exclude in test
@ravinkohli ravinkohli deleted the reg_cocktails_apt1.0+reg_cocktails_pytorch_embedding_reduced branch March 17, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ravinkohli