Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Documentation update in base_trainer.py #468

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

theodorju
Copy link
Collaborator

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

I have updated the documentation of base_trainer for #406 in places where it seemed reasonable to add documentation.

Motivation and Context

Changes fix #406. This pull request includes the changes after the comments on PR 447 which reported additional changes due to rebase.

How has this been tested?

Since the changes are only in the documentation, I have not executed any tests for this issue.

Copy link
Contributor

@ravinkohli ravinkohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think it can be merged.

@theodorju theodorju merged commit 34c704d into automl:reg_cocktails Aug 12, 2022
@theodorju theodorju deleted the reg_cocktails-406 branch September 6, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants