Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable wheels for 32/64 architecture #184

Merged
merged 6 commits into from
May 27, 2021
Merged

Conversation

franchuterivera
Copy link
Contributor

  • Enable wheels on a similar fashion as pyrfr
  • Fixes an overflow for 32 bits systems --> np.int is too big to fix c-type long. So I am moving to long long type for the below operations.

@franchuterivera
Copy link
Contributor Author

This PR has an extra line that we need to remove (this) so that I can check your comments :D

Before merging we should remove it

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #184 (659bebf) into master (b2fe51e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   68.20%   68.22%   +0.01%     
==========================================
  Files          18       18              
  Lines        1774     1775       +1     
==========================================
+ Hits         1210     1211       +1     
  Misses        564      564              
Impacted Files Coverage Δ
ConfigSpace/read_and_write/pcs_new.py 88.00% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fe51e...659bebf. Read the comment docs.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you maybe add a comment on top of the wheel workflow file describing how to trigger the wheel building action?

@franchuterivera
Copy link
Contributor Author

Please let me know if this message Is informative enough

#
# However, artifacts are only uploaded to a release
# here: https://github.com/automl/ConfigSpace/releases
# When a release tag is created. For example, if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, could you please be more specific here? In particular, does it have to be a release (I think that's github nomenclature) or a tag (that's git nomenclature)? I think it would also be good if you could briefly add the steps that are required to be done from the command line.

@mfeurer mfeurer merged commit f639133 into automl:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants