-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable wheels for 32/64 architecture #184
Conversation
franchuterivera
commented
May 20, 2021
- Enable wheels on a similar fashion as pyrfr
- Fixes an overflow for 32 bits systems --> np.int is too big to fix c-type long. So I am moving to long long type for the below operations.
This PR has an extra line that we need to remove (this) so that I can check your comments :D Before merging we should remove it |
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 68.20% 68.22% +0.01%
==========================================
Files 18 18
Lines 1774 1775 +1
==========================================
+ Hits 1210 1211 +1
Misses 564 564
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Could you maybe add a comment on top of the wheel workflow file describing how to trigger the wheel building action?
Please let me know if this message Is informative enough |
.github/workflows/wheels.yml
Outdated
# | ||
# However, artifacts are only uploaded to a release | ||
# here: https://github.com/automl/ConfigSpace/releases | ||
# When a release tag is created. For example, if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, could you please be more specific here? In particular, does it have to be a release (I think that's github nomenclature) or a tag (that's git nomenclature)? I think it would also be good if you could briefly add the steps that are required to be done from the command line.