Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMAC class name in latest version #112

Closed
ndangtt opened this issue Dec 16, 2019 · 3 comments · Fixed by #114
Closed

SMAC class name in latest version #112

ndangtt opened this issue Dec 16, 2019 · 3 comments · Fixed by #114
Assignees
@shukon

Comments

@ndangtt
Copy link

ndangtt commented Dec 16, 2019

Hello,

I saw that current PIMP source code has the same issue as mentioned here, and thought that I should mention that to you!

These are the line with the issue:

ParameterImportance/pimp/pimp.py

Line 15 in 45e776f

from smac.facade.smac_facade import SMAC

ParameterImportance/pimp/pimp.py

Line 34 in 45e776f

smac: Union[SMAC, None] = None,

Best regards,
Nguyen
@AndreBiedenkapp
Copy link
Collaborator

Oh thank you very much for reporting the issue.
That was unfortunately overlooked.

@ndangtt
Copy link
Author

ndangtt commented Dec 16, 2019

You're very welcome! Thank you for looking at it so quickly! :)

Nguyen

shukon added a commit that referenced this issue Dec 27, 2019
@shukon
FIX #112 smac-facade newest version
5b7d6e3
@shukon shukon mentioned this issue Dec 27, 2019
Merged
@shukon
Copy link
Collaborator

shukon commented Dec 27, 2019

Sorry, lost this in my stack. Fixed in #113 and will be released asap.

@shukon shukon mentioned this issue Dec 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shukon shukon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.0.7 automl/ParameterImportance
3 participants
@AndreBiedenkapp @shukon @ndangtt