Fix: Keyword arguments to submit get caught
#1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiebergman
changed the title
submit get caughtsubmit get caught
eddiebergman
added a commit
that referenced
this pull request
Feb 18, 2022
This was referenced Feb 18, 2022
[Bug in
development] run_wrapper() got an unexpected keyword argument 'pure'
automl/Auto-PyTorch#383
Closed
eddiebergman
added a commit
that referenced
this pull request
Feb 21, 2022
* Fix: Implement hotfix from #1407, aimed at master * Add: Argument to ExecuteTaFuncWithQueue * Add: multi_objectives arg to tests * Fix: Two more locations of `multi_objectives`
johnantonn
added a commit
to johnantonn/auto-sklearn
that referenced
this pull request
Feb 25, 2022
Fix: Keyword arguments to `submit` get caught (automl#1407)
github-actions bot
pushed a commit
to helloneel/auto-sklearn
that referenced
this pull request
Apr 5, 2022
github-actions bot
pushed a commit
to LUH-DBS/AutoClean
that referenced
this pull request
Apr 7, 2022
eddiebergman
added a commit
that referenced
this pull request
Apr 21, 2022
This reverts commit 6cc8bb1.
eddiebergman
added a commit
that referenced
this pull request
Apr 21, 2022
This reverts commit 53844b4.
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
* Fix: Implement hotfix from #1407, aimed at master * Add: Argument to ExecuteTaFuncWithQueue * Add: multi_objectives arg to tests * Fix: Two more locations of `multi_objectives`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1406 where the keyword arguments for
SingleThreadedClientwhich inherits fromdask.distributed.Clientwere not being caught before being forwarded to thefuncit executes with**kwargs.