Add build to requirements.txt #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spillai
reviewed
Sep 22, 2023
| @@ -1,4 +1,5 @@ | |||
| av>=10.0.0 | |||
| build | |||
There was a problem hiding this comment.
FYI we have a requirements.dev.txt that is an alternative to this file, and meant for build environments (probably that needs to be installed in CI). This requirements txt file is for clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build(required formake dist) does not seem to be included inpython<=3.10, which is causing pypi build flows to build in github actions. I've added it to the mainrequirements.txtfile for now to finish out the CI flow.Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.