Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to sidestep a hairy issue where the
.whl
distribution name doesn't quite match that supplied to thepyproject.toml
via python version import. Specifically, it replaces-
with.
and appends a trailing 0, neither of which are found in the $NOS_VERSION. Workaround is to grep for the base version with some name mangling. Also setting up twine permissions to pull uname and password as github secrets so we can keep these out of the repo.twine
needs to be a dependency alongsidebuild
. Moved these torequirements.dev.txt
, need to confirm they still get installed withdevelop-cpu
.Checks
make lint
: I've runmake lint
to lint the changes in this PR.make test
: I've made sure the tests (make test-cpu
ormake test
) are passing.