Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twine upload on release #350

Merged
merged 9 commits into from
Sep 24, 2023
Merged

Twine upload on release #350

merged 9 commits into from
Sep 24, 2023

Conversation

outtanames
Copy link
Contributor

@outtanames outtanames commented Sep 24, 2023

Attempting to sidestep a hairy issue where the .whl distribution name doesn't quite match that supplied to the pyproject.toml via python version import. Specifically, it replaces - with . and appends a trailing 0, neither of which are found in the $NOS_VERSION. Workaround is to grep for the base version with some name mangling. Also setting up twine permissions to pull uname and password as github secrets so we can keep these out of the repo. twine needs to be a dependency alongside build. Moved these to requirements.dev.txt, need to confirm they still get installed with develop-cpu.

Checks

  • make lint: I've run make lint to lint the changes in this PR.
  • make test: I've made sure the tests (make test-cpu or make test) are passing.
  • Additional tests:
    • Benchmark tests (when contributing new models)
    • GPU/HW tests

@outtanames
Copy link
Contributor Author

outtanames commented Sep 24, 2023

Local upload looks good with twine upload --verbose --repository testpypi torch_nos-0.0.11.dev0-py3-none-any.whl. Ready to test with pre-release.

@outtanames outtanames merged commit e032f71 into main Sep 24, 2023
1 check passed
@outtanames
Copy link
Contributor Author

Run looks good, failed due to collision with existing package (which shouldn't be an issue on an actual release) https://github.com/autonomi-ai/nos/actions/runs/6293127864/job/17083227757

@spillai spillai deleted the sloftin/twine-dependency branch September 26, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant