Update profiling records without reseting catalog #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests for these? |
spillai
reviewed
Jan 15, 2024
nos/common/profiler.py
Outdated
| @@ -228,6 +228,22 @@ def as_df(self) -> pd.DataFrame: | |||
| ) | |||
| return df | |||
|
|
|||
| def from_df(self, df: pd.DataFrame) -> None: | |||
There was a problem hiding this comment.
This needs to be a classmethod where you return cls(records)
There was a problem hiding this comment.
@classmethod
def from_df(cls, df: pd.DataFrame) -> "Profiler":
...
return cls(records)
spillai
reviewed
Jan 15, 2024
nos/common/profiler.py
Outdated
| record.update(key, value) | ||
| self.records.append(record) | ||
|
|
||
| def from_json_path(self, filename: Union[Path, str]) -> None: |
There was a problem hiding this comment.
Same comment as above, needs to be a classmethod that returns return cls.from_df(df)
spillai
reviewed
Jan 15, 2024
nos/common/profiler.py
Outdated
| self.prof = Profiler() | ||
| self.prof.from_json_path(NOS_PROFILE_CATALOG_PATH) | ||
| else: | ||
| logger.debug("No prof catalog found") |
There was a problem hiding this comment.
Use f"Profile catalog not found (filename={NOS_PROFILE_CATALOG_PATH})."
spillai
reviewed
Jan 15, 2024
nos/common/profiler.py
Outdated
| with Profiler() as self.prof, torch.inference_mode(): | ||
| from nos.constants import NOS_PROFILE_CATALOG_PATH | ||
|
|
||
| self.prof = Profiler() |
There was a problem hiding this comment.
self.prof = Profiler.from_json_path(NOS_PROFILE_CATALOG_PATH)
outtanames
force-pushed
the
sloftin/inline-profiling-records
branch
from
ae09f21
to
49b158e
Compare
spillai
changed the title
…rofiler, profiling data and profiling context managers
… the hub based on profile path, gpu utilization populates now
…ult for profiling
outtanames
force-pushed
the
sloftin/inline-profiling-records
branch
from
0c0c126
to
c2b6b9f
Compare
…ferent key strucure. Init an empty profiler by default and require rebuild
see additions, we now check for gpu utilization in the catalog for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variety of updates/fixes to the profiler to support generating profiling catalogs across local/cloud:
profless ambiguous between the Profiler itself, context managers, actual profiling results etc.--catalog-pathflag so we can write profiling results to a filemount in skypilot rather than needing to track down the catalog inside the nos cache each time.Summary
Related issues
Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.