Override ModelDeploymentSpec of registered models
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows users to override the deployment spec of registered models.
For example, registered models and their deployment spec can be overridden as follows:
```yaml
TinyLlama/TinyLlama-1.1B-Chat-v1.0:
runtime_env: custom-gpu
deployment:
resources:
device: auto
device_memory: 3Gi
```
In this example, the deployment resources for the model
`TinyLlama/TinyLlama-1.1B-Chat-v1.0` will be overridden to use
the `custom-gpu` runtime environment and `3Gi` of device memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows users to override the deployment spec of registered models. For example, registered models and their deployment spec can be overridden as follows:
In this example, the deployment resources for the model
TinyLlama/TinyLlama-1.1B-Chat-v1.0will be overridden to use thecustom-gpuruntime environment and3Giof device memory.Related issues
Resolves #518
Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.