Skip to content

Commit

Permalink
feat(testkit): update minSdk, targetSdk, compileSdk, and an equals af…
Browse files Browse the repository at this point in the history
…ter applicationId and namespace (#1187)
  • Loading branch information
j-roskopf authored May 23, 2024
1 parent be75f27 commit dec044a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ public class AndroidBlock @JvmOverloads constructor(
private fun renderKotlin(scribe: Scribe): String = scribe.block(this) { s ->
if (namespace != null) {
s.line {
it.append("namespace \"")
it.append("namespace = \"")
it.append(namespace)
it.append("\"")
}
}
s.line {
it.append("compileSdkVersion = ")
it.append("compileSdk = ")
it.append(compileSdkVersion)
}
defaultConfig.render(s)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ public class DefaultConfig @JvmOverloads constructor(
private fun renderKotlin(scribe: Scribe): String = scribe.block(this) { s ->
if (applicationId != null) {
s.line {
it.append("applicationId ")
it.append("applicationId = ")
it.appendQuoted(applicationId)
}
}
s.line {
it.append("minSdkVersion = ")
it.append("minSdk = ")
it.append(minSdkVersion)
}
s.line {
it.append("targetSdkVersion = ")
it.append("targetSdk = ")
it.append(targetSdkVersion)
}
s.line {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,12 +498,12 @@ internal class ScribeTestKotlin {
version = "$version"
android {
namespace "ankh.morpork"
compileSdkVersion = 34
namespace = "ankh.morpork"
compileSdk = 34
defaultConfig {
applicationId "com.example"
minSdkVersion = 21
targetSdkVersion = 29
applicationId = "com.example"
minSdk = 21
targetSdk = 29
versionCode = 1
versionName = "1.0"
}
Expand Down

0 comments on commit dec044a

Please sign in to comment.