Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU plotting preparation #3004

Merged
merged 5 commits into from
Sep 5, 2024
Merged

GPU plotting preparation #3004

merged 5 commits into from
Sep 5, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Sep 4, 2024

Some changes extracted from local branch that will be helpful for GPU plotting when it is introduced.

rust-kzg repo update is needed to include grandinetech/rust-kzg#263 that we'll be using in FFI calls to GPU.

K constant was not previously explicitly exposed for proof of space and pool plotter will allow us to combine CPU and GPU plotters into one virtual plotter.

Code contributor checklist:

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are some "invalid Scalar" errors in the tests, but I can't find where they are coming from in the code changes. Maybe they're from a dependency change?

@nazar-pc
Copy link
Member Author

nazar-pc commented Sep 4, 2024

Yeah, looks like caused by blst upgrade, I'll take a look at it

@nazar-pc
Copy link
Member Author

nazar-pc commented Sep 4, 2024

And here is the reason: grandinetech/rust-kzg#265

@nazar-pc
Copy link
Member Author

nazar-pc commented Sep 4, 2024

@dariolina see ethereum/c-kzg-4844#305 and linked PRs, should we switch to big-endian encoding after Gemini 3h as well?

@dariolina
Copy link
Member

Ugh...
We would want to keep compatibility aspirations with Ethereum. As long as commitments to different vectors are still unique and verifiable, we should be fine
Can you try the switch and see if our encoded public KZG parameters still match ?

@nazar-pc
Copy link
Member Author

nazar-pc commented Sep 4, 2024

KZG parameters are irrelevant here, this is about data processing during archiving and plotting

@dariolina
Copy link
Member

Then that data processing where the endianess matters is not part of consensus, so it depends if you have counter-arguments why not switch?

@nazar-pc
Copy link
Member Author

nazar-pc commented Sep 4, 2024

I do not have any counter-arguments, but we can only do that after Gemini 3h

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't have enough context to fully approve.

@nazar-pc nazar-pc added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit f73c757 Sep 5, 2024
11 checks passed
@nazar-pc nazar-pc deleted the gpu-plotting-preparation branch September 5, 2024 12:35
@nazar-pc nazar-pc mentioned this pull request Sep 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants