Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas import error on RPi #1015

Merged
merged 1 commit into from
May 23, 2022

Conversation

DocGarbanzo
Copy link
Contributor

@DocGarbanzo DocGarbanzo commented May 23, 2022

RPi pandas import error when using auto generated tubs

When using AUTO_CREATE_NEW_TUB = True, we import the legacy datastore.py module for the TubHandler class. However, that module specifies a pandas import at module level. We don't install pandas on RPi by default to keep the python package smaller. This behaviour has been reported in #1010.

This is fixed by:

  • Move the pandas import from module level into the Tub and TubGroup classes as otherwise we have an import error on RPi when the config AUTO_CREATE_NEW_TUB is set to True.

  • Bump the version.

…asses as otherwise we have an import error on RPi when the config AUTO_CREATE_NEW_TUB is set to True.

Bump the version.
Copy link
Contributor

@Ezward Ezward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@DocGarbanzo DocGarbanzo merged commit 8504345 into autorope:main May 23, 2022
@DocGarbanzo DocGarbanzo deleted the fix_pandas_dependency_on_pi branch May 23, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants