Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI bug fixes and improvements #1045

Merged
merged 1 commit into from
Oct 15, 2022
Merged

UI bug fixes and improvements #1045

merged 1 commit into from
Oct 15, 2022

Conversation

DocGarbanzo
Copy link
Contributor

Improvements and fixes in Donkey UI

  • When no tub or config is loaded, clicking transport buttons in the tub manager or pilot screen lead to ungraceful program aborts. Similarly clicking on augmentation controls. This is now handled better.
  • Fixes in logger statements that lead to exceptions
  • Improvement in the handling of the filter functionality in the tub manager screen: This filter will now be exported into the config such that it gets picked up in the training. This allows to use the filter in training without manually editing the config file.

@DocGarbanzo
Bump version
53082ee 
Improve UI to allow filter in tub manager to be passed through into the trainer.

Fix UI behaviour to better cope with uninitialised widgets when the user has no config or no tub loaded and starts clicking buttons.
@DocGarbanzo DocGarbanzo changed the title UI bug fixes an improvement UI bug fixes and improvements Oct 11, 2022
@DocGarbanzo DocGarbanzo added the UI label Oct 11, 2022
Ezward
Ezward approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@Ezward Ezward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DocGarbanzo DocGarbanzo merged commit 00c4c03 into autorope:main Oct 15, 2022
@DocGarbanzo DocGarbanzo deleted the ui_bug_fixes branch October 16, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ezward Ezward Ezward approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DocGarbanzo @Ezward