Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clamp differential drive throttle and steering #983

Merged
merged 1 commit into from
Jan 30, 2022
Merged

clamp differential drive throttle and steering #983

merged 1 commit into from
Jan 30, 2022

Conversation

Ezward
Copy link
Contributor

@Ezward Ezward commented Jan 19, 2022

  • the throttle and steering passed to TwoWheelSteeringThrottle where just a 3/1000 over 1, but where triggering the check against a max of 1.
  • this caused the differential drive cars to fail when trying to run the linear model.
  • this commit simply clamps out of range values to the allowed range of -1 to 1 inclusive.

See @Rushil issue in discord https://discordapp.com/channels/662098530411741184/671604367706554388/932156905818828861

@Ezward
clamp differential drive throttle and steering
39db6e2 
- the throttle and steering passed to TwoWheelSteeringThrottle
  where just a 3/1000 over 1, but where triggering the
  check against a max of 1.
- this commit simply clamps out of range values to the
  allowed range of -1 to 1 inclusive.
@Ezward Ezward self-assigned this Jan 19, 2022
DocGarbanzo
DocGarbanzo approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - you might want to bump the version, too.

@Ezward Ezward merged commit b19d4c7 into dev Jan 30, 2022
@Ezward Ezward deleted the clamp-differential-drive-throttle-steering branch January 30, 2022 20:42
@luigidiguglielmo-devel luigidiguglielmo-devel mentioned this pull request Mar 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DocGarbanzo DocGarbanzo DocGarbanzo approved these changes

Assignees

@Ezward Ezward

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ezward @DocGarbanzo