Specify myconfig in training #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ezward
requested changes
Mar 16, 2022
donkeycar/management/base.py
Outdated
| def parse_args(self, args): | ||
| parser = argparse.ArgumentParser(prog='calibrate', usage='%(prog)s [options]') | ||
| parser.add_argument( |
There was a problem hiding this comment.
Seems like the pwm-pin part of calibration has been removed. That means that the user cannot calibrate with the same pin configuration as the will use in their drivetrain. So for instance, what if they are using gpio to generate pwm? Was this removed for a reason?
There was a problem hiding this comment.
Thanks for spotting this, this is a mistake coming from my rebase, reverted that change.
donkeycar/management/base.py
Outdated
| input_prompt = "Enter a PWM setting to test ('q' for quit) (0-180): " | ||
|
|
||
| elif args.pwm_pin is not None: |
There was a problem hiding this comment.
Same thing here. Is there a reason the pwm_pin calibration argument was removed?
There was a problem hiding this comment.
Similar error, coming from bad rebase, reverted this.
DocGarbanzo
commented
Mar 16, 2022
| print("personal config: file not found ", personal_cfg_path) | ||
|
|
||
| # derived settings | ||
| if hasattr(cfg, 'IMAGE_H') and hasattr(cfg, 'IMAGE_W'): |
There was a problem hiding this comment.
These config variables are not used.
DocGarbanzo
force-pushed
the
specify_myconfig_in_training
branch
2 times, most recently
from
bcd39ae
to
e310752
Compare
DocGarbanzo
force-pushed
the
specify_myconfig_in_training
branch
from
e310752
to
da2e9ec
Compare
DocGarbanzo
added a commit
that referenced
this pull request
Apr 22, 2022
DocGarbanzo
added a commit
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable myconfig.py selection
When training from the command line using
donkey trainwe can now add a path to a differentmyconfg.pyfile. This was reported as issue #976.