-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfe: Introduce ruff-pre-commit #4139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulYuuu
force-pushed
the
pre-commit-ruff
branch
3 times, most recently
from
August 23, 2024 03:00
d75de87
to
1a02de4
Compare
PaulYuuu
force-pushed
the
pre-commit-ruff
branch
from
September 18, 2024 07:15
1a02de4
to
59a755b
Compare
PaulYuuu
changed the title
rfe: Introuce ruff-pre-commit
rfe: Introduce ruff-pre-commit
Oct 23, 2024
PaulYuuu
force-pushed
the
pre-commit-ruff
branch
from
October 23, 2024 05:21
59a755b
to
56df290
Compare
yanan-fu
previously approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
YongxueHong
previously approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM, |
XueqiangWei
previously approved these changes
Oct 23, 2024
zhencliu
previously approved these changes
Oct 23, 2024
PaulYuuu
dismissed stale reviews from zhencliu, XueqiangWei, YongxueHong, and yanan-fu
via
October 23, 2024 08:19
c5511d0
PaulYuuu
force-pushed
the
pre-commit-ruff
branch
from
October 23, 2024 08:19
56df290
to
c5511d0
Compare
Ruff is a fast, extensible Python linter designed to catch common issues in Python code, such as syntax errors, stylistic inconsistencies, and potential bugs. Signed-off-by: Yihuang Yu <[email protected]>
pylint E203 conflicts with black style, so disable it, also manual fix some E0606 issues after ruff format. Signed-off-by: Yihuang Yu <[email protected]>
PaulYuuu
force-pushed
the
pre-commit-ruff
branch
from
October 23, 2024 08:30
c5511d0
to
43fb9d8
Compare
Update the branch to resolve all conflicts. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfe: Introduce ruff-pre-commit
Ruff is a fast, extensible Python linter designed to catch common issues
in Python code, such as syntax errors, stylistic inconsistencies, and
potential bugs.
ID: 2802
Depends on: #4077