Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfe: Introduce ruff-pre-commit #4139

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

PaulYuuu
Copy link
Contributor

@PaulYuuu PaulYuuu commented Aug 22, 2024

rfe: Introduce ruff-pre-commit

Ruff is a fast, extensible Python linter designed to catch common issues
in Python code, such as syntax errors, stylistic inconsistencies, and
potential bugs.

ID: 2802
Depends on: #4077

@PaulYuuu PaulYuuu changed the title chore: Support pre-commit rfe: Introuce ruff-pre-commit Aug 22, 2024
@PaulYuuu PaulYuuu force-pushed the pre-commit-ruff branch 3 times, most recently from d75de87 to 1a02de4 Compare August 23, 2024 03:00
@PaulYuuu PaulYuuu changed the title rfe: Introuce ruff-pre-commit rfe: Introduce ruff-pre-commit Oct 23, 2024
yanan-fu
yanan-fu previously approved these changes Oct 23, 2024
Copy link
Contributor

@yanan-fu yanan-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

YongxueHong
YongxueHong previously approved these changes Oct 23, 2024
Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XueqiangWei
Copy link
Contributor

LGTM,
Acked-by: [email protected]

XueqiangWei
XueqiangWei previously approved these changes Oct 23, 2024
zhencliu
zhencliu previously approved these changes Oct 23, 2024
Ruff is a fast, extensible Python linter designed to catch common issues
in Python code, such as syntax errors, stylistic inconsistencies, and
potential bugs.

Signed-off-by: Yihuang Yu <[email protected]>
pylint E203 conflicts with black style, so disable it, also manual fix
some E0606 issues after ruff format.

Signed-off-by: Yihuang Yu <[email protected]>
@PaulYuuu
Copy link
Contributor Author

Update the branch to resolve all conflicts. Thanks all.

@PaulYuuu PaulYuuu merged commit 477e22c into autotest:master Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants