Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovmf_check_efi: change sgdisk to parted #4159

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

XueqiangWei
Copy link
Contributor

Due to the deletion of sgdisk in the latest linux, change sgdisk to parted in this case

Signed-off-by: Xueqiang Wei [email protected]
ID: 2880

@XueqiangWei
Copy link
Contributor Author

(1/2) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.x86_64.io-github-autotest-qemu.ovmf_check_efi.q35: PASS (54.63 s)
(2/2) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.ovmf_check_efi.q35: PASS (83.89 s)

@XueqiangWei
Copy link
Contributor Author

@zhencliu, Could you please help review it? Many thanks.

@@ -2,7 +2,7 @@
only q35
only ovmf
type = ovmf_check_efi
check_cmd = "gdisk -l /dev/[vs]da"
check_cmd = "parted -l /dev/[vs]da"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @XueqiangWei , parted -l will list partition layout on all block devices, of course, in your case, only one device is configured, can we remove /dev/[vs]da?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks Zhenchao.

@XueqiangWei XueqiangWei force-pushed the ovmf_check_efi branch 2 times, most recently from f2a33b2 to 6d33cc0 Compare September 18, 2024 09:28
Due to the deletion of sgdisk in the latest linux,
change sgdisk to parted in this case

Signed-off-by: Xueqiang Wei <[email protected]>
@XueqiangWei
Copy link
Contributor Author

(1/1) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.ovmf_check_efi.q35: PASS (60.82 s)

@XueqiangWei
Copy link
Contributor Author

@zhencliu Could you please help review it again? Many thanks.

@XueqiangWei
Copy link
Contributor Author

Zhenchao, Many thanks.

@XueqiangWei XueqiangWei merged commit 6e65746 into autotest:master Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants